-
Notifications
You must be signed in to change notification settings - Fork 799
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PHPCS: Widget Visibility #22414
PHPCS: Widget Visibility #22414
Conversation
Caution: This PR has changes that must be merged to WordPress.com |
Thank you for your PR! When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:
This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖 The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available. Once your PR is ready for review, check one last time that all required checks (other than "Required review") appearing at the bottom of this PR are passing or skipped. Jetpack plugin:
|
Regarding the file renaming e187b02 Just verifying I would: get this PR merged, deploy the wpcom diff, then modify the filename being synced in |
Yes, although I would recommend committing to WordPress.com in 2 diffs: one to add the new file, another to start requiring that file instead of the existing one. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me. 🚢
Great news! One last step: head over to your WordPress.com diff, D73402-code, and commit it. Thank you! |
r238622-wpcom |
Changes proposed in this Pull Request:
PHPCS cleanup Widget Visibility module files.
Jetpack product discussion
Fixes #21979
Does this pull request change what data or activity we track or use?
No.
Testing instructions: